[wp-trac] [WordPress Trac] #36824: do_all_pings function queries all posts

WordPress Trac noreply at wordpress.org
Thu Sep 19 01:49:05 UTC 2019


#36824: do_all_pings function queries all posts
--------------------------------------+---------------------------
 Reporter:  spacedmonkey              |       Owner:  boonebgorges
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  Pings/Trackbacks          |     Version:  2.1
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"46175" 46175]:
 {{{
 #!CommitTicketReference repository="" revision="46175"
 Improve `do_enclose()` logic on post publish.

 Removing the direct SQL query in `do_all_pings()` improves filterability.

 As part of this change, the signature of `do_enclose()` is changed so that
 a null `$content` parameter can be passed, with the `$content` then
 inferred
 from the `$post` passed in the second parameter. In addition, the second
 parameter was modified so that a post ID or a `WP_Post` object can be
 provided. These changes make it possible to trigger enclosure checks with
 a post ID alone (as in `do_all_pings()`) and also brings the function
 signature in line with `do_trackbacks()` and `pingback()`.

 Props dshanske, spacedmonkey, janw.oostendorp, mrmadhat, birgire.
 See #36824.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36824#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list