[wp-trac] [WordPress Trac] #36824: do_all_pings function queries all posts

[WordPress Trac]

#36824: do_all_pings function queries all posts
--------------------------------------+---------------------------
 Reporter:  spacedmonkey              |       Owner:  boonebgorges
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  Pings/Trackbacks          |     Version:  2.1
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+---------------------------

Comment (by dshanske):

 Replying to [comment:53 boonebgorges]:
 > [attachment:"36824-enclosures.diff"] includes only the changes to
 enclosures. Questions for feedback:
 >
 > 1. I've removed some of the miscellaneous changes to `do_enclose()`.
 These are generally OK but should be moved to different tickets.
 >
 > 2. Similar to [comment:52 my concern 1 about pingbacks], I wonder if we
 should be querying all post types, rather than limiting to those that are
 `publicly_queryable`.

 Here I would agree with you it should be all, as enclosures are a matter
 of identifying embedded media. Mostly used for RSS, you could in theory
 have a private RSS feed, for example.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36824#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform