[wp-trac] [WordPress Trac] #47708: 5.3 about page
WordPress Trac
noreply at wordpress.org
Wed Oct 30 00:34:30 UTC 2019
#47708: 5.3 about page
-------------------------------------+----------------------------
Reporter: karmatosed | Owner: johnbillion
Type: task (blessed) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Help/About | Version:
Severity: normal | Resolution:
Keywords: i18n-change needs-patch | Focuses: accessibility
-------------------------------------+----------------------------
Comment (by azaozz):
Replying to [comment:85 ryelle]:
> Right, this new design changes a lot about the page, so the intention
was to leave the existing CSS in place for a cycle for any plugins that
might use the about classes in their own pages. We can remove this all in
an early patch in 5.4, so folks have more time to update.
Right. Makes sense.
> ...and an ie-rtl file that I didn't know exists and looks like it hasn't
been touched since before 4.8.
Yeah, ie.css and ie-rtl.css are old old IE6-compat CSS! Was meant to make
wp-admin "somewhat useful" in super old versions of IE. That was around...
WP 3.5 I believe :) Don't think it makes anything work now, lets remove it
at the beginning of 5.4 too.
> Aside from the notice, do you know of any plugins that do this? I don't
think there are any other places _to_ hook in to add content.
Both `admin-header.php` and `admin-footer.php` are included on the About
screens. Don't think there would be any "problematic" HTML in the footer
but there are few hooks in `admin-header.php` that seem used by plugins,
the "notice" hooks and `do_action( 'in_admin_header' )`. As these fire
outside the sections can assume they are "safe". Still maybe worth a quick
"all plugins code" search to see if a plugin isn't doing something weird,
but such cases would probably have been reported by now for recent
releases.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:93>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list