[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-------------------------------------+----------------------------
 Reporter:  karmatosed               |       Owner:  johnbillion
     Type:  task (blessed)           |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.3
Component:  Help/About               |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  i18n-change needs-patch  |     Focuses:  accessibility
-------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-patch i18n-change => i18n-change needs-patch


Comment:

 Looking at the latest changes committed in trunk, there are a few contrast
 issues to address:

 **Inactive "tabs:"**
 text and background color don't pass the required 4.5:1 contrast ratio:
 `#7B776C` on `#FEFCF7`
 Luminosity Contrast Ratio: 4.36:1
 https://jdlsn.com/color/?type=hex&color=7B776C&color2=FEFCF7

 [[Image(http://cldup.com/nls6NLpnkI.png)]]

 **Links within the dark beige (not sure it's the proper color name?)
 boxes:**
 `#0073aa` on `#D7D2C5`
 Luminosity Contrast Ratio: 3.45:1
 https://jdlsn.com/color/?type=hex&color=0073aa&color2=D7D2C5

 [[Image(http://cldup.com/OnN-wFkefP.png)]]

 > Text zoom: Fixed this by using ems for the height, since we do still
 want to cap the min & max heights.

 Thanks for fixing it :) Though I still see text overlapping at high text
 zoom levels. Still not sure why the heights need to be fixed, could you
 please expand on that?

 > Tabs: Yep, that's how it should look.

 Thanks for clarifying, though it doesn't make sense to me that UI elements
 that look like "tabs" are then stacked vertically on small screens.

 Aside: maybe I'm missing something but I don't see any discussion on the
 introduction of CSS variables. This would be the first time CSS variables
 are introduced in core and I'd tend to think this kind of new
 implementation should be at least discussed a bit, as it always happened
 in the past.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:92>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform