[wp-trac] [WordPress Trac] #45529: Correct phpdoc example for Internal Pointers

[WordPress Trac]

#45529: Correct phpdoc example for Internal Pointers
------------------------------------------+--------------------------------
 Reporter:  daleharrison                  |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  normal                        |   Milestone:  5.3
Component:  Administration                |     Version:  3.3
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch commit 2nd-opinion  |     Focuses:  docs, coding-
                                          |  standards
------------------------------------------+--------------------------------

Comment (by jrf):

 @desrosj Good point.

 The thing is, in this case:
 1. Using a separate function would make the code sample even longer
 (though yes, it would comply with the coding standards better).
 2. The closure is used to remove the action and, while it can not be
 unhooked, an `add_action()` at prio 12 could easily re-add the removed
 action.

 So, I'm in two minds about this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45529#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform