[wp-trac] [WordPress Trac] #45529: Correct phpdoc example for Internal Pointers
WordPress Trac
noreply at wordpress.org
Thu Oct 3 19:14:47 UTC 2019
#45529: Correct phpdoc example for Internal Pointers
------------------------------------------+--------------------------------
Reporter: daleharrison | Owner: (none)
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.3
Component: Administration | Version: 3.3
Severity: normal | Resolution:
Keywords: has-patch commit 2nd-opinion | Focuses: docs, coding-
| standards
------------------------------------------+--------------------------------
Changes (by desrosj):
* keywords: has-patch commit => has-patch commit 2nd-opinion
* owner: desrosj => (none)
Comment:
While I am not opposed to [attachment:"45529.3.diff"], I did want to
question the use of a closure on an action hook.
The latest updates to the coding standards established that:
> Closures must not be passed as filter or action callbacks, as they
cannot be removed by `remove_action()` / `remove_filter()`
Because of that, I am hesitant to introduce this as the recommended
example here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45529#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list