[wp-trac] [WordPress Trac] #48449: Parameters differ between instances of widget_comments_args filter
WordPress Trac
noreply at wordpress.org
Sat Nov 30 08:21:12 UTC 2019
#48449: Parameters differ between instances of widget_comments_args filter
---------------------------+------------------------------
Reporter: johnbillion | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Comments | Version: 5.0
Severity: normal | Resolution:
Keywords: needs-testing | Focuses:
---------------------------+------------------------------
Comment (by SergeyBiryukov):
Thanks for the patch!
I don't think we can just remove the `$instance` parameter from the
filter, as that could cause backward compatibility issues and would be
inconsistent with other widget filters, as seen in [41685].
I guess we can pass an empty array as `$instance` in
`render_block_core_latest_comments()`, but that should be done upstream in
the Gutenberg repository, per comment:5:ticket:48447.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48449#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list