[wp-trac] [WordPress Trac] #48449: Parameters differ between instances of widget_comments_args filter

[WordPress Trac]

#48449: Parameters differ between instances of widget_comments_args filter
---------------------------+------------------------------
 Reporter:  johnbillion    |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Comments       |     Version:  5.0
 Severity:  normal         |  Resolution:
 Keywords:  needs-testing  |     Focuses:
---------------------------+------------------------------
Changes (by fahdi):

 * keywords:  needs-patch => needs-testing


Comment:

 I have attached the patch for the solution that I believe is good. The
 solution is to either add an`instance` argument for the filter in the file

 https://core.trac.wordpress.org/browser/tags/5.2.4/src/wp-includes/blocks
 /latest-comments.php?marks=46-53#L35

 which doesn't make any sense as we don't  have any way to pass an
 instance. Looking at

 https://core.trac.wordpress.org/browser/tags/5.2.4/src/wp-includes/widgets
 /class-wp-widget-recent-comments.php?marks=99-107#L86 , just removing
 instance from the parameters should solve and now we have the  same
 consistent number of  parameters  in both calls.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48449#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform