[wp-trac] [WordPress Trac] #47632: Coding Standards fixes for WP 5.3

[WordPress Trac]

#47632: Coding Standards fixes for WP 5.3
----------------------------+-------------------------------
 Reporter:  pento           |       Owner:  pento
     Type:  task (blessed)  |      Status:  closed
 Priority:  normal          |   Milestone:  5.3
Component:  General         |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:                  |     Focuses:  coding-standards
----------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:50 Otto42]:
 > Hey @pento, this is a bug. Potentially a bad one.
 >
 > {{{
 > if ( ! $this->is_dir( $path ) || ! $this->is_readable( $dir ) ) {
 >     return false;
 > }
 >
 > $dir = dir( $path );
 > }}}
 >
 > $dir isn't set in the check here. is_readable $dir is always false.

 It was fixed the same day in [45613] / #47668.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47632#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform