[wp-trac] [WordPress Trac] #47632: Coding Standards fixes for WP 5.3

[WordPress Trac]

#47632: Coding Standards fixes for WP 5.3
----------------------------+-------------------------------
 Reporter:  pento           |       Owner:  pento
     Type:  task (blessed)  |      Status:  reopened
 Priority:  normal          |   Milestone:  5.3
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  coding-standards
----------------------------+-------------------------------
Changes (by Otto42):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:7 pento]:
 > In [changeset:"45611" 45611]:
 > {{{
 > #!CommitTicketReference repository="" revision="45611"
 > Coding Standards: Fix instances of
 `WordPress.PHP.NoSilencedErrors.Discouraged`.
 >
 > Noteable changes:
 > - The `magic_quotes_runtime` and `magic_quotes_sybase` settings were
 removed in PHP 5.4, so no longer need to be set.
 > - Some functions that use external libraries can generate errors that
 can't be tested for, so are globally allowed to silence errors.
 > - Quite a few functions would cause errors if `safe_mode` was set. This
 setting was removed in PHP 5.4.
 > - Only a handful of `header()` calls needed corresponding
 `headers_sent()` checks for unit tests to pass, but more may need to be
 added as the nightlies builds are tested.
 >
 > See #46732.
 > }}}

 Hey @pento, this is a bug. Potentially a bad one.

 {{{
 if ( ! $this->is_dir( $path ) || ! $this->is_readable( $dir ) ) {
     return false;
 }

 $dir = dir( $path );
 }}}

 $dir isn't set in the check here. is_readable $dir is always false.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47632#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform