[wp-trac] [WordPress Trac] #46938: Prevent activation of incompatible plugins without valid readme.txt

[WordPress Trac]

#46938: Prevent activation of incompatible plugins without valid readme.txt
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Plugins                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  servehappy has-patch dev-feedback    |     Focuses:
  needs-testing                                  |
-------------------------------------------------+-------------------------

Comment (by afragen):

 Replying to [comment:14 Otto42]:
 > Realistically, I'm surprised that we added parsing of the readme.txt for
 these in the first place. They should have been in the plugin's main PHP
 file all along.
 >
 > Historically, the readme.txt for plugins has only been used by the
 WordPress.org directory. This provided a clear separation. WordPress reads
 the PHP file, the directory reads the readme.txt file for other things not
 in the PHP file's headers.
 >
 > So, my 2 cents is to instead add reading these headers to the plugin's
 PHP file, and give precedence to that instead of the readme.txt file.

 I initially wrote the patch giving the precedence to the currently
 available information. It should be easy to switch.

 > With a possible long term goal being to undo this mistake, and eliminate
 reliance on the readme.txt file from core itself. Readme.txt files are
 *not* required files for plugins, and never have been. We cannot rely on
 them being present.
 >

 While readme.txt files aren’t required; neither are the plugin headers. My
 thought is that as long as the compatibility information exists in one of
 these places it should be utilized and in time required.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46938#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform