[wp-trac] [WordPress Trac] #47169: Use a non-zero exit code when requirements are not met

[WordPress Trac]

#47169: Use a non-zero exit code when requirements are not met
-----------------------------------+---------------------
 Reporter:  jrf                    |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  5.2.1
Component:  Build/Test Tools       |     Version:  3.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------

Comment (by jrf):

 FYI: Tested @SergeyBiryukov's patch with a command-line plugin unit test
 run and found working (exit code 1 is thrown with a nice error message
 without PHP errors).

 > However, this also means that wp-includes/functions.php needs to remain
 parsable by earlier PHP versions going forward if we ever decide to switch
 to 5.6+ or 7+ syntax.

 That seems like a pretty big trade-off for a slightly nicer message
 layout.

 We may need to revisit when this check is done and whether the message
 should be translatable, rather sooner than later.

 Just as an example: With the improvements in PHP 5.5's
 Internationalization extension, we could ''finally'' solve the remaining
 unicode issues, but if messages like this need to stay translatable, we
 are doomed to keep using `getText`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47169#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform