[wp-trac] [WordPress Trac] #47169: Use a non-zero exit code when requirements are not met

[WordPress Trac]

#47169: Use a non-zero exit code when requirements are not met
-----------------------------------+---------------------
 Reporter:  jrf                    |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  5.2.1
Component:  Build/Test Tools       |     Version:  3.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------

Comment (by SergeyBiryukov):

 Replying to [comment:8 spacedmonkey]:
 > I think that the patch
 [https://core.trac.wordpress.org/attachment/ticket/47169/47169.patch
 47169.patch] seems reasonable to me, but I haven't tested it yet.
 >
 > I think it is reasonable to get this in 5.2 (maybe 5.2.1) and we can
 change over to use `wp_die` if possible in 5.3+.

 [attachment:"47169.2.patch"] changes these messages to use `wp_die()`, for
 consistency with what was done for other functions:

 * [44827] `dead_db()`
 * [45019] `wp_maintenance()`
 * [45030] `wp_check_mysql_version()`

 However, this also means that `wp-includes/functions.php` needs to remain
 parsable by earlier PHP versions going forward if we ever decide to switch
 to 5.6+ or 7+ syntax.

 [attachment:"47169.patch"] seems like a quick win, maybe that would be
 enough here?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47169#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform