[wp-trac] [WordPress Trac] #46750: Twenty Nineteen: Add styles to support the group block

[WordPress Trac]

#46750: Twenty Nineteen: Add styles to support the group block
---------------------------------------+---------------------
 Reporter:  kjellr                     |       Owner:  (none)
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  5.3
Component:  Bundled Theme              |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+---------------------

Comment (by kjellr):

 Thank you so much for testing, @laurelfulford! I truly appreciate it.

 > In the editor, the full-width image blocks bleed out of the group for me

 I think this is actually just related to this Gutenberg issue:

 https://github.com/WordPress/gutenberg/issues/16284

 Should be all set as of Gutenberg v6.0 — would you mind giving those
 another test?

 > I've got a bit of side-scrolling too (not specific to these changes or
 this block, it looks like) so that might be related.

 I do see a _super_ tiny bit of side scrolling in the editor too, at least
 when using the test data. I'll dig in a bit and see if I can find the
 source (and whether or not it's due to this patch or not).

 > In the editor, full-width columns are slightly indented in the standard
 and wide-width groups (but display as expected in full-width groups)

 Yeah, I think this is a core Gutenberg bug, as it's showing up all themes
 I've tried. I've filed a bug for it here:

 https://github.com/WordPress/gutenberg/issues/16321

 In the meantime, I don't think we should make any adjustments for it here.

 > And this might be getting into the weeds, but Twenty Nineteen has styles
 that switch text to white when you set a darker background colour. It
 looks like this works sometimes with the group block -- like tables,
 paragraphs and lists all switch to white. Some -- like the verse -- won't
 switch in the editor, but do on the front-end. Others -- captions,
 citations -- don't switch at all.
 >
 > I also can't get the pullquote to preview a changed colour in the editor
 when nested in a group block with a background -- it stays white in the
 editor, but will display correctly on the front-end.
 >
 > I feel like this one may be a bit of a whack-a-mole to fix, so I wanted
 to raise it and just get your thoughts.

 Ugh, those are really annoying. I agree that it's likely a whack-a-mole
 sort of fix. If it makes sense to you, I'd prefer to get this patch in as
 is, and then address those separately. I anticipate a lot of trial and
 error there. 😅

 I'll take a look at the horizontal scrolling issue before we do a final
 pass — I'll have an update on that in the next day or two.

 Thanks again!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46750#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform