[wp-trac] [WordPress Trac] #46750: Twenty Nineteen: Add styles to support the group block

[WordPress Trac]

#46750: Twenty Nineteen: Add styles to support the group block
---------------------------------------+---------------------
 Reporter:  kjellr                     |       Owner:  (none)
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  5.3
Component:  Bundled Theme              |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+---------------------

Comment (by laurelfulford):

 This is looking awesome, @kjellr! I'm excited to see this block on the
 horizon, and working so nicely in the theme:

 I found a few odds and ends while testing:

 In the editor, the full-width image blocks bleed out of the group for me:

 Wide:
 [[Image(https://cldup.com/q8XsNoMCJW-3000x3000.png)]]

 Full:
 [[Image(https://cldup.com/xjB-V1wLHe-3000x3000.png)]]

 I've got a bit of side-scrolling too (not specific to these changes or
 this block, it looks like) so that might be related.

 In the editor, full-width columns are slightly indented in the standard
 and wide-width groups (but display as expected in full-width groups):

 [[Image(https://cldup.com/Z3O7E3Xnnl-3000x3000.png)]]

 If the group has floated items, they can 'pop out' of it -- I'm not sure
 if it should have a "clearfix" or not (and if this should be a theme-level
 thing, or a block-level one).

 [[Image(https://cldup.com/rlUbm78Q8x-3000x3000.png)]]

 On mobile-sized screens, a few of the blocks -- Gallery, Cover, and Media
 & Text -- don't display at full-width when nested in standard or wide-
 width group blocks when they have a background colour (they do when nested
 in full-width group blocks):

 [[Image(https://cldup.com/l9y_IMMEcp-3000x3000.png)]]

 If the group block doesn't have a background colour, they do display full
 width.

 And this might be getting into the weeds, but Twenty Nineteen has styles
 that switch text to white when you set a darker background colour. It
 looks like this works sometimes with the group block -- like tables,
 paragraphs and lists all switch to white. Some -- like the verse -- won't
 switch in the editor, but do on the front-end. Others -- captions,
 citations -- don't switch at all.

 I also can't get the pullquote to preview a changed colour in the editor
 when nested in a group block with a background -- it stays white in the
 editor, but will display correctly on the front-end.

 Examples in the editor:

 [[Image(https://cldup.com/8rqoSIBAlE-3000x3000.png)]]

 Trying to change the pullquote to black:

 [[Image(https://cldup.com/2nvfzF2G0B-3000x3000.png)]]

 Same blocks on the front-end:

 [[Image(https://cldup.com/CcebI2XyP6-3000x3000.png)]]

 I feel like this one may be a bit of a whack-a-mole to fix, so I wanted to
 raise it and just get your thoughts.

 Just let me know if you have any questions about the above!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46750#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform