[wp-trac] [WordPress Trac] #47223: Site Health Check: "last missed cron" test too aggressive
WordPress Trac
noreply at wordpress.org
Sat Jun 22 09:56:31 UTC 2019
#47223: Site Health Check: "last missed cron" test too aggressive
-------------------------------------------------+-------------------------
Reporter: DavidAnderson | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future
| Release
Component: Site Health | Version: 5.2
Severity: normal | Resolution:
Keywords: site-health has-patch needs-testing | Focuses:
-------------------------------------------------+-------------------------
Comment (by peterwilsoncc):
@rockfire Thanks for uploading the patch.
I've uploaded [attachment:"47223.2.diff"] which includes a few minor
coding standards fixes and modifies the docblock slightly.
As the function is `public` and changes the return type, it is a break of
backward compatibility which is something WordPress aims to maintain. I'm
going to consider a way forward without breaking it.
The return value is still truthy but a plugin or theme author using a
strict type check on the function's return value will get either false
positives or negatives.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47223#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list