[wp-trac] [WordPress Trac] #47487: Classic Editor plugin link and link target

WordPress Trac noreply at wordpress.org
Sun Jun 9 16:47:27 UTC 2019


#47487: Classic Editor plugin link and link target
-------------------------+----------------------------
 Reporter:  derweili     |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.3
Component:  Editor       |     Version:  5.2.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  accessibility
-------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-patch needs-testing => has-patch


Comment:

 Thanks for working on this. Quickly tested and the `esc_url ...` in one
 line is OK. Instead, phpcs complains for the closing `?>` and asks for one
 more tab. Which doesn't make sense to me, but this is the current state of
 the CS rules 🤷🏻‍♂️

 I'd consider to improve the translators comment.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47487#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list