[wp-trac] [WordPress Trac] #47487: Classic Editor plugin link and link target

[WordPress Trac]

#47487: Classic Editor plugin link and link target
-------------------------------------+----------------------------
 Reporter:  derweili                 |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  5.3
Component:  Editor                   |     Version:  5.2.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility
-------------------------------------+----------------------------
Changes (by garrett-eclipse):

 * keywords:  needs-patch => has-patch needs-testing
 * focuses:   => accessibility
 * milestone:  Future Release => 5.3


Comment:

 Thanks for flagging this @derweili and for the initial patch, made it easy
 to find what link you were referring to.

 @SergeyBiryukov I appreciate the input and direction, I've pulled the
 internal install link which was committed here;
 https://core.trac.wordpress.org/changeset/44264

 This links to the custom install screen made for the Classic Editor
 plugin. For reference here's the link code;
 `esc_url( wp_nonce_url( self_admin_url( 'plugin-
 install.php?tab=favorites&user=wordpressdotorg&save=0' ),
 'save_wporg_username_' . get_current_user_id() ) )`

 My patch
 [https://core.trac.wordpress.org/attachment/ticket/47487/47487.2.diff
 47487.2.diff] implements this URL replacing the translatable external
 plugin link.

 This loads the custom favorites tab of the plugin install screen for the
 wordpressdotorg user which is specifically favourited Classic Editor, also
 has nonce to restore the users favorites.

 Sergey can you review the link setup for CS I wasn't sure since it was
 inside an expanded sprintf if the esc_url, wp_nonce_url and self_admin_url
 calls should all be on individual lines indented or if the shortform I'm
 using passes formatting.

 Please test,
 Thank you

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47487#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform