[wp-trac] [WordPress Trac] #25473: wp_text_diff creates wrong number of columns if title arguments are set

WordPress Trac noreply at wordpress.org
Wed Aug 21 18:27:59 UTC 2019


#25473: wp_text_diff creates wrong number of columns if title arguments are set
---------------------------------------+------------------------------
 Reporter:  joedolson                  |       Owner:  adamsilverstein
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.3
Component:  Revisions                  |     Version:  3.6.1
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  accessibility
---------------------------------------+------------------------------

Comment (by adamsilverstein):

 > To my understanding, these are more "compare from" vs. compare to
 columns.

 @afercia this is a common misunderstanding.

 In fact the left column always shows what has been removed and the right
 column always shows what is added (in the current comparison). Some
 additional context is shown so you can tell where you are in the document,
 but the highlighted area is always additions on the right and deletions on
 the left.

 You can prove this to yourself by creating a post and publishing, then add
 or remove one line and update, do this a few times then go to revisions
 and check what is shown. each time you remove a line, that change is shown
 in the left. when you add a line, that change is shown on the right.

 This confusion has always bothered me, and I much prefer the **single
 column view** (`show_split_view` set to false)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/25473#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list