[wp-trac] [WordPress Trac] #25473: wp_text_diff creates wrong number of columns if title arguments are set

WordPress Trac noreply at wordpress.org
Wed Aug 21 16:06:11 UTC 2019


#25473: wp_text_diff creates wrong number of columns if title arguments are set
---------------------------------------+------------------------------
 Reporter:  joedolson                  |       Owner:  adamsilverstein
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.3
Component:  Revisions                  |     Version:  3.6.1
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  accessibility
---------------------------------------+------------------------------

Comment (by afercia):

 > Re: the table headers "Base revision" and "Compared revision": any
 suggestion for better wording and styling is welcome.

 @adamsilverstein thanks for reviewing and adjusting! :) I'm not sure the
 new default left/right title are ideal. Maybe I'm missing something but:
 `'title_left'      => __( 'Removed' )`
 `'title_right'     => __( 'Added' )`

 the left column may not necessarily have "removed" content, and the right
 one may not have "added" content. To my understanding, these are more
 "compare from" vs. `compare to` columns.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/25473#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list