[wp-trac] [WordPress Trac] #46704: Twenty Nineteen: Long non-breaking text strings can cause horizontal scrolling

[WordPress Trac]

#46704: Twenty Nineteen: Long non-breaking text strings can cause horizontal
scrolling
-------------------------------------------------+-------------------------
 Reporter:  ianbelanger                          |       Owner:
                                                 |  ianbelanger
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.2
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots commit     |     Focuses:
  needs-refresh                                  |
-------------------------------------------------+-------------------------
Changes (by ianbelanger):

 * keywords:  has-patch has-screenshots commit => has-patch has-screenshots
     commit needs-refresh


Comment:

 Replying to [comment:12 laurelfulford]:
 > Thanks for tackling this, @ianbelanger! I noticed a couple things while
 reviewing [attachment:46704.diff] :
 >
 > * The RTL stylesheet needs to be regenerated as well with these changes
 (it's the one default theme that doesn't load the default style.css with
 the RTL styles). This can be done by running `npm install` and `npm run
 build` inside of the theme's folder.

 Oops, I forgot about that. I'll refresh the patch after building the
 theme.

 > * In headings.scss, `.post-navigation .post-title, .entry-title, .not-
 found .page-title...` already has `word-break: break-word` -- I don't
 think the `word-wrap: break-word;` is needed there, too (unless I'm
 missing something!).

 The reason for adding `word-wrap: break-word;` was to appease IE and Edge.
 `word-break: break-word;` does not work with them.

 > * It looks like Edge and IE 10-11 will also support hyphens with the
 -ms- prefix -- do you think it's worth adding that as well?
 >

 Yes I do, good catch! I will add them in the updated patch, coming soon.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46704#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform