[wp-trac] [WordPress Trac] #46894: Personal Data Export Report: Table of contents for easier navigation

Sun Apr 14 21:23:11 UTC 2019

#46894: Personal Data Export Report: Table of contents for easier navigation
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui
  refresh                                        |
-------------------------------------------------+-------------------------

Comment (by garrett-eclipse):

 P.S. Now that `grunt test` completed it's showing there's 4 phpunit issues
 due to the email contents being changed without their corresponding tests
 being updated.

 {{{
 There were 4 failures:

 1) Tests_Privacy_WpPrivacyGeneratePersonalDataExportFile::test_contents
 Failed asserting that '<!DOCTYPE html>\n
 <html>\n
 <head>\n
 <meta http-equiv='Content-Type' content='text/html; charset=UTF-8' />\n
 <style type='text/css'>body { color: black; font-family: Arial, sans-
 serif; font-size: 11pt; margin: 15px auto; width: 860px; }table {
 background: #f0f0f0; border: 1px solid #ddd; margin-bottom: 20px; width:
 100%; }th { padding: 5px; text-align: left; width: 20%; }td { padding:
 5px; }tr:nth-child(odd) { background-color: #fafafa; }#table_of_contents {
 padding: 10px 0 10px 0; }.return_to_table_of_contents { text-align:right;
 }</style><title>Personal Data Export for export-
 requester at example.com</title></head>\n
 <body>\n
 <h1>Personal Data Export</h1><div id="table_of_contents"><a
 href="#About">About</a></div><h2
 id="About">About</h2><div><table><tbody><tr><th>Report generated
 for</th><td>export-requester at example.com</td></tr><tr><th>For
 site</th><td>Test Blog</td></tr><tr><th>At URL</th><td><a
 href="http://example.org">http://example.org</a></td></tr><tr><th>On</th><td>2019-04-14
 21:17:52</td></tr></tbody></table><div
 class="return_to_table_of_contents"><a href="#table_of_contents">Return to
 table of contents</a></div></div></body>\n
 </html>\n
 ' contains "<h2>About</h2>".

 /Users/garretthyder/WordPress/46894-export-
 toc/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportFile.php:264

 2)
 Tests_Privacy_WpPrivacyGeneratePersonalDataExportGroupHtml::test_group_html_generation_single_data_item
 Failed asserting that '<h2 id="Test_Data_Group">Test Data
 Group</h2><div><table><tbody><tr><th>Field 1 Name</th><td>Field 1
 Value</td></tr><tr><th>Field 2 Name</th><td>Field 2
 Value</td></tr></tbody></table><div class="return_to_table_of_contents"><a
 href="#table_of_contents">Return to table of contents</a></div></div>'
 contains "<h2>Test Data Group</h2>".

 /Users/garretthyder/WordPress/46894-export-
 toc/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportGroupHtml.php:45

 3)
 Tests_Privacy_WpPrivacyGeneratePersonalDataExportGroupHtml::test_group_html_generation_multiple_data_items
 Failed asserting that '<h2 id="Test_Data_Group">Test Data
 Group</h2><div><table><tbody><tr><th>Field 1 Name</th><td>Field 1
 Value</td></tr><tr><th>Field 2 Name</th><td>Field 2
 Value</td></tr></tbody></table><table><tbody><tr><th>Field 1
 Name</th><td>Another Field 1 Value</td></tr><tr><th>Field 2
 Name</th><td>Another Field 2 Value</td></tr></tbody></table><div
 class="return_to_table_of_contents"><a href="#table_of_contents">Return to
 table of contents</a></div></div>' contains "<h2>Test Data Group</h2>".

 /Users/garretthyder/WordPress/46894-export-
 toc/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportGroupHtml.php:83

 4)
 Tests_Privacy_WpPrivacyGeneratePersonalDataExportGroupHtml::test_group_labels_escaped
 Failed asserting that '<h2
 id="<div>Escape_HTML_in_group_lavels</div>"><div>Escape
 HTML in group lavels</div></h2><div><div
 class="return_to_table_of_contents"><a href="#table_of_contents">Return to
 table of contents</a></div></div>' contains "<h2><div>Escape HTML in
 group lavels</div></h2>".

 /Users/garretthyder/WordPress/46894-export-
 toc/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportGroupHtml.php:139
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46894#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform