[wp-trac] [WordPress Trac] #46894: Personal Data Export Report: Table of contents for easier navigation

[WordPress Trac]

#46894: Personal Data Export Report: Table of contents for easier navigation
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui
  refresh                                        |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch needs-
     refresh


Comment:

 Thanks for the initial patch @xkon

 It applies nicely and introduces the TOC as expected.

 Some thoughts;
 1. Should we use sanitize_title or esc_url on the anchors? Some plugins
 will have special characters, and many languages will as well.
 2. Should we enable plugins to provide a $group_toc_label so they can
 provide a shortened version of their Group Label. In many cases the label
 used by plugins can be quite long which wouldn't be as appropriate for the
 TOC, so wondering if we allow for a group_toc_label and fall back to the
 group_label otherwise and for back-compat.
 3. When there's no data there's no poitn of a TOC for just the 'About'
 section. Also when there's just one more section in most browsers there's
 not enough content to make it worth anchors as no scroll action is
 possible. Am wondering if we just start at '>1' to enable the
 functionality otherwise it feels broken as it doesn't do anything.
 *I would normally agree be consistent, but when there's link on the screen
 and they don't appear to cause an action they feel broken.

 All the best,
 Cheers

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46894#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform