[wp-trac] [WordPress Trac] #46098: Help notice displayed on Privacy Policy page missing in block editor

[WordPress Trac]

#46098: Help notice displayed on Privacy Policy page missing in block editor
----------------------------------------------+----------------------------
 Reporter:  aduth                             |       Owner:  garrett-
                                              |  eclipse
     Type:  defect (bug)                      |      Status:  reopened
 Priority:  normal                            |   Milestone:  5.2
Component:  Privacy                           |     Version:  5.0
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |     Focuses:
                                              |  administration
----------------------------------------------+----------------------------

Comment (by aduth):

 Ah, right you are. I'd missed it in my review. The updated patch looks
 good. I note the small difference of the space occurring outside the
 screen reader `span` where before it'd been contained within. In the
 browser, it appears to make no difference and the trailing whitespace is
 collapsed. As proposed appears to be the more common convention elsewhere
 in the codebase as well.

 It occurs to me that the `target` attribute shouldn't need to be inserted
 using placeholder substitution. I suppose it was arguably more necessary
 when the link was translateable. Do you think it ought to be removed now?
 A similar point could be made about the screen reader text element, though
 there may be an argument in favor of general code legibility to keeping
 the substitution.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46098#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform