[wp-trac] [WordPress Trac] #46640: Classic Editor: the distraction-free button breaks keyboard navigation

[WordPress Trac]

#46640: Classic Editor: the distraction-free button breaks keyboard navigation
----------------------------------------------+----------------------------
 Reporter:  afercia                           |       Owner:  (none)
     Type:  defect (bug)                      |      Status:  new
 Priority:  normal                            |   Milestone:  5.3
Component:  Editor                            |     Version:
 Severity:  normal                            |  Resolution:
 Keywords:  has-screenshots has-patch commit  |     Focuses:  accessibility
----------------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     has-patch commit


Comment:

 Oh yes [attachment:"46640.3.diff"] is the best of both worlds: fixes
 keyboard navigation and preserves the intended UI. Tested, work nicely.
 Thanks @azaozz !

 Any objections to move this to 5.2, which means committing very soon? 😄

 > the PHP changes in 46640.diff are a bit more readable

 Yep, it was a readability vs. stylistic thing. If the nested if/else is
 not a concern, I have no strong preferences thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46640#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform