[wp-trac] [WordPress Trac] #46640: Classic Editor: the distraction-free button breaks keyboard navigation
WordPress Trac
noreply at wordpress.org
Thu Apr 11 20:53:13 UTC 2019
#46640: Classic Editor: the distraction-free button breaks keyboard navigation
-------------------------------------------------+-------------------------
Reporter: afercia | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.3
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch needs- | Focuses:
testing | accessibility
-------------------------------------------------+-------------------------
Changes (by azaozz):
* keywords: has-screenshots has-patch => has-screenshots has-patch needs-
testing
Comment:
Replying to [comment:9 afercia]:
> The main issue is the broken keyboard navigation.
Yeah I see. Tried to fix this in 46640.3.diff. Disabling the button
through TinyMCE's API seems to exclude it from the (js controlled)
navigation there. Please test :)
> [attachment:"46640.diff"] and [attachment:"46640.2.diff"] do basically
the same thing.
Right, but the PHP changes in 46640.diff are a bit more readable imho, can
easily see which button is after which :)
In 46640.3.diff:
- Based on the previous diffs.
- Show and hide the `dfw` button through the editor API.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46640#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list