[wp-trac] [WordPress Trac] #43857: Show the comment / awaiting moderation message even without opt-in

[WordPress Trac]

#43857: Show the comment / awaiting moderation message even without opt-in
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:  javorszky
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.9
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-       |     Focuses:
  refresh                                        |
-------------------------------------------------+-------------------------
Changes (by javorszky):

 * keywords:  has-patch needs-testing => has-patch needs-testing needs-
               refresh


Comment:

 My username (which is my last name) is missing a 'z'. :)

 Things I'm missing at the moment:

 * refreshed patch - using the docs here:
 https://make.wordpress.org/core/handbook/testing/patch/, applying the
 patch via the grunt way fails to apply 2 of 3 hunks, so it doesn't seem
 like I can test this in any meaningful way as of this moment
 * as someone who's new to testing this part of the code, I need a few
 steps to set up the opening state of things. What settings should
 WordPress have, how to have a user submit a comment without consent, etc?
 * then a way to see what this patch should be solving. For example: "If
 (after common setup steps) user does X, without this patch, this happens.
 With the patch, this other thing happens". Gifs and screenshots help.

 Replying to [comment:47 robdxw]:
 > @javorsky Is there anything I can do to help get this in 4.9.9? Unit
 tests are all passing, and I've done some local testing which all seems
 ok. But it's not clear from
 [https://make.wordpress.org/core/handbook/testing/patch/] whether that's
 sufficient, or if anything else is required.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43857#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform