[wp-trac] [WordPress Trac] #45178: 5.0 About Page

[WordPress Trac]

#45178: 5.0 About Page
----------------------------+---------------------
 Reporter:  pixelverbieger  |       Owner:  (none)
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  5.0
Component:  Help/About      |     Version:  5.0
 Severity:  normal          |  Resolution:
 Keywords:  needs-design    |     Focuses:
----------------------------+---------------------

Comment (by lonelyvegan):

 I'd echo everything @afercia mentioned and say that in general avoiding
 modals in this UX would be nice. I think pointing folks to the Featured
 Plugin section is probably fine.

 I have no idea how to comment on diff's in Trac, but I see some HTML
 inside a translation string in:
 {{{
 <a href="%s">Classic Editor</a>
 }}}

 I think the entire start/end tag should be escaped ala `src/wp-
 admin/about.php` around line 30.

 The {{{ Give it a try }}} link also seems a bit out of a context and might
 be jarring for a screenreader experience. {{{ Give the Twenty Ninteteen
 theme a try }}} or something, while wordier, is clearer. If you can fit
 that in: I recommend it.

 For the styles in:

 {{{
 .about-wrap figcaption
 }}}

 and

 {{{
 .about-wrap figcaption
 }}}

 there are some whitespace issues; looks like mixed tabs and spaces.

 Finally, I noticed:

 {{{
 .about-wrap .eight-col .col
 }}}

 has an `!important` flag: it'd be nice to leave a comment as to why that
 is. I always find I'm confused about `!important`s when I see them—often I
 try to remove them but don't have context for why they were used in the
 first place—so I think it's handy to explain why they were necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45178#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform