[wp-trac] [WordPress Trac] #44142: Load Order: save_mod_rewrite_rules assumes wp-admin/includes/file.php is loaded

[WordPress Trac]

#44142: Load Order: save_mod_rewrite_rules assumes wp-admin/includes/file.php is
loaded
----------------------------+-----------------------
 Reporter:  YuriV           |       Owner:  kraftbj
     Type:  defect (bug)    |      Status:  assigned
 Priority:  normal          |   Milestone:  4.9.7
Component:  Bootstrap/Load  |     Version:  4.9.6
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------

Comment (by azaozz):

 > What about indicating that rules should only be flushed within wp-admin
 within the flush_rewrite_rules function that is typically called, as seen
 in 44142.3.diff?

 Yeah, makes sense.

 > I'd be more comfortable with landing this notice in a major release...

 Makes sense too. Also perhaps we can add to the "doing it wrong" message
 that flushing the rules is acceptable only in development.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44142#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform