[wp-trac] [WordPress Trac] #44142: Load Order: save_mod_rewrite_rules assumes wp-admin/includes/file.php is loaded

[WordPress Trac]

#44142: Load Order: save_mod_rewrite_rules assumes wp-admin/includes/file.php is
loaded
----------------------------+-----------------------
 Reporter:  YuriV           |       Owner:  kraftbj
     Type:  defect (bug)    |      Status:  assigned
 Priority:  normal          |   Milestone:  4.9.7
Component:  Bootstrap/Load  |     Version:  4.9.6
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:17 kraftbj]:
 > What about indicating that rules should only be flushed within wp-admin
 within the `flush_rewrite_rules` function that is typically called, as
 seen in 44142.3.diff?

 [attachment:44142.3.diff] has a non-zero chance of displaying unexpected
 notices on front end if someone accidentally has `WP_DEBUG` enabled on
 production.

 Developer Reference has an
 [https://developer.wordpress.org/reference/functions/flush_rewrite_rules/#comment-599
 example of flushing rewrite rules on front end every 48 hours] for theme
 development.

 I'd be more comfortable with landing this notice in a major release with a
 dev note written at beta stage than in an automatically installed minor
 update.

 I have no objections to the notice in `wp_add_privacy_policy_content()`
 though, since that's new functionality.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44142#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform