[wp-trac] [WordPress Trac] #42437: Thumbnails can overwrite other uploads if filename matches

WordPress Trac noreply at wordpress.org
Tue May 15 22:41:13 UTC 2018


#42437: Thumbnails can overwrite other uploads if filename matches
--------------------------+-----------------------------
 Reporter:  Viper007Bond  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Upload        |     Version:  4.8.3
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------------

Comment (by pbiron):

 Replying to [comment:14 joemcgill]:
 > The best way I can think of avoiding these kinds of conflicts is to add
 a short hash to filenames of intermediate image sizes to ensure that this
 is unique.

 How would such a hash be any better than the `-1`, `-2`, etc that
 [[https://developer.wordpress.org/reference/functions/wp_unique_filename/|wp_unique_filename()]]
 adds?

 [just seeking clarification, not criticizing the idea]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42437#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list