[wp-trac] [WordPress Trac] #42437: Thumbnails can overwrite other uploads if filename matches

WordPress Trac noreply at wordpress.org
Tue May 15 22:08:58 UTC 2018


#42437: Thumbnails can overwrite other uploads if filename matches
--------------------------+-----------------------------
 Reporter:  Viper007Bond  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Upload        |     Version:  4.8.3
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------------

Comment (by pbiron):

 Replying to [comment:3 azaozz]:
 > Thinking we should be stripping things like `-1024x768` from the ends of
 image names on upload. That will allow "proper" naming with -2, -3, etc.
 for duplicates and will prevent sub-sizes name conflicts.

 Looking back through the Slack thread, I see this
 [[https://wordpress.slack.com/archives/C02SX62S6/p1516911806000384?thread_ts=1516911292.000510&cid=C02SX62S6|comment
 by @desrosj]]

   I would not be in favor of this. While WordPress may try to use that
 filename, that could be a very purposeful filename.

 with which I agree.

 Another example of a "purposeful" filename that contains a
 "dimension"-like sub-string that is completely unrelated to the image
 dimensions is `our-store-is-open-24x7.jpg` :-)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42437#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list