[wp-trac] [WordPress Trac] #43481: Add tabs and placeholders to privacy tools page in wp-admin

[WordPress Trac]

#43481: Add tabs and placeholders to privacy tools page in wp-admin
------------------------------+------------------------------
 Reporter:  xkon              |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  General           |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  gdpr 2nd-opinion  |     Focuses:
------------------------------+------------------------------

Comment (by xkon):

 For: [attachment:43481.6.diff]

 OK! Let me go through the list because I have like 10 different .diff(s)
 now locally that are not even published here and it is starting to get a
 bit messy.

 From @allendav :

 * Change `WordPress Core' to `WordPress`: fixed
 * Replace `Anonymize` Flow with `Export`: I merged Erasure / Anonymization
 but this can be renamed again ( needs chat ).
 * `esc_attr_e`: fixed
 * `type key`: turned to lowercase (this might change with according to
 what other tickets in the future want to get over it)

 ---

 From @birgire :

 * `esc_url()`: fixed on both `$edit_href`, `$view_href`
 * `striped` class: fixed
 * `include()` & `require_once()`: I didn't touch these as that's how all
 admin pages have them at the moment.
 * `.hide()` in `xfn.js`: fixed
 * `js flickering issue`: fixed, I passed everything in CSS on a default
 state
 * `TOC instead of tabs on information`: fixed, I left the idea of 'tabed'
 content instead of a full list underneath the link index as we don't know
 how much information plugins will output yet

 Extra things from @birgire for chat:

 `Row actions instead of buttons`: yes we could do that and it would make
 the tables a lot simpler imho as well
 `State column`: I think not as when you export or delete the request will
 probably be removed as well?
 `Order + Pagination`: we could do that but let's get this in and move with
 other tickets as well first imho

 ---

 Extra things added:

 * `Tables responsive`: since the tables where too big for small screens I
 just added an `overflow-x` for now and we can see in the future how to get
 that properly managed
 * `Manual E-mail Export / Erasure boxes`: Admins might as well need to
 export or anonymize / delete data without having a request so that option
 should be given somewhere. For now I just placed some extra boxes on the
 side as they don't take up much space.
 * `No requests`: If there are no requests now the table will just display
 a message instaed of just removing the whole box. Since all websites will
 pretty much start 'empty' it woudln't look nice to just have boxes on the
 Right side with the main content showing nothing.

 ---

 Any extra input is always more than welcome but let's try to finalize this
 and don't go over minor-things for now as all of these are always subject
 to change. Don't forget it's meant to just be a base so we can work on the
 other tickets as well so the other tickets can actually alter / add /
 remove things from the UI as well as we proceed with them.

 (Hopefully I didn't forget something again ! :D )

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43481#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform