[wp-trac] [WordPress Trac] #43481: Add tabs and placeholders to privacy tools page in wp-admin

[WordPress Trac]

#43481: Add tabs and placeholders to privacy tools page in wp-admin
------------------------------+------------------------------
 Reporter:  xkon              |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  General           |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  gdpr 2nd-opinion  |     Focuses:
------------------------------+------------------------------

Comment (by birgire):

 This seems to be in a good progress.

 Here are few additional suggestions after reviewing
 [attachment:43481.5.diff]:

 - Use {{{esc_url( $edit_href )}}} and {{{esc_url( $view_href )}}} when
 using in HTML.
 - Use the {{{striped}}} class on the request tables, to get alternating
 background for each row.
 - Change {{{include()}}} to {{{require_once}}} without brackets.
 - Change require_once() to {{{require_once}}} without brackets.
 - Use {{{.hide()}}} instead of {{{.css( 'display', 'none' )}}} in
 {{{xfn.js}}}.
 - When the page loads, the non-active tabs are hidden with JS, could we do
 that via CSS instead to avoid the flickering?
 - Should HTML tags in translation strings be avoided here? See e.g.
 #41645, #39898, #35988.

 Also wondering in general about:
 - The plugin tabs when there are many plugins, as some sites have 100+
 plugins. The new "System Information" page in progress uses e.g. table-of-
 contents links.
 - The case when there are hundreds of requests - pagination?
 - If it would make sense to have the row actions like in the list tables?
 They show up when we hover over each row. Many large blue action buttons
 take a lot of visual attention.
 - Is there a need for a "state" column, to show what has been done to that
 request?
 - Allow the user to order requests by date, email or full name?
 - If a plugin wants to link to the plugin information tab? Would it make
 sense to have it deep-linkable?

 Hope it helps.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43481#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform