[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

WordPress Trac noreply at wordpress.org
Fri Jun 22 15:03:01 UTC 2018


#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  Iceable
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  accessibility,
  patch dev-feedback has-            |  javascript
  screenshots 2nd-opinion has-ux-    |
  feedback                           |
-------------------------------------+-------------------------------------
Changes (by boemedia):

 * keywords:
     good-first-bug has-patch dev-feedback has-screenshots 2nd-opinion ux-
     feedback
     =>
     good-first-bug has-patch dev-feedback has-screenshots 2nd-opinion has-
     ux-feedback


Comment:

 With the help of @adamsilverstein (thanks a lot!), I installed a clean
 local dev environment and tested the patch again. It now works fine, and I
 think it would be a great improvement for usability.

 Two things to take in consideration:

 - with super long passwords (that seem to be trendy these days ;)), the
 box is not showing the full length of characters. The font size is rather
 large compared to the field size. Do we need to restrict the login and
 password box to this size, or could it be slightly bigger? That, combined
 with a smaller font size maybe?
 - on mobile view, the 'eye' overlaps with the password field. Either give
 the 'eye' a white background, but ideally, here a bigger field size would
 be better too.

 See my screenshots for clarification.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list