[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  Iceable
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  accessibility,
  patch dev-feedback has-            |  javascript
  screenshots 2nd-opinion ux-        |
  feedback                           |
-------------------------------------+-------------------------------------
Changes (by boemedia):

 * keywords:
     good-first-bug has-patch dev-feedback has-screenshots has-ux-feedback
     2nd-opinion ux-feedback
     =>
     good-first-bug has-patch dev-feedback has-screenshots 2nd-opinion ux-
     feedback


Comment:

 Me & @Iceable briefly sat together during WCEU contributor day. We checked
 this on both mine (MAMP) and his (VVV) local environment, but there was a
 difference in display. We couldn't quite replicate what caused the display
 being wrong on my install (we did use grunt build) because of time and
 wifi issues, I have to see if I can get VVV installed on my computer and
 test again. Maybe someone else can test on MAMP and see if they can
 replicate my issue?

 Replying to [comment:20 adamsilverstein]:
 > @boemedia can you please give this another test following the steps
 @Iceable outlined? notably, use grunt patch and grunt build to make sure
 the patch applies to the correct code and is built into the build
 directory.. Also, since https://core.trac.wordpress.org/changeset/43309
 you'll need to be testing by running WordPress from the build directory as
 well.
 >
 > Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform