[wp-trac] [WordPress Trac] #43142: Do not warm term meta cache unnecessarily

WordPress Trac noreply at wordpress.org
Tue Jan 30 17:48:05 UTC 2018


#43142: Do not warm term meta cache unnecessarily
---------------------------+--------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  5.0
Component:  Taxonomy       |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  performance
---------------------------+--------------------------

Comment (by boonebgorges):

 Thanks for taking a closer look, @peterwilsoncc. The functional changes
 look good to me.

 [attachment:43142.3.diff] includes two coding standards changes:

 1. No spaces in `$args['parent']`
 2. You broke each argument for `wp_get_object_terms()` into its own line.
 This is not a strict violation of the coding standards, but I haven't seen
 this specific function use this formatting before. I changed it to what I
 see as the more common format. But maybe this could use advice from @jrf.
 (See right-hand 2460 in [attachment:43142.3.diff] and
 [attachment:43142.2.diff] )

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43142#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list