[wp-trac] [WordPress Trac] #43142: Do not warm term meta cache unnecessarily

WordPress Trac noreply at wordpress.org
Sun Jan 28 22:39:25 UTC 2018


#43142: Do not warm term meta cache unnecessarily
---------------------------+--------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  5.0
Component:  Taxonomy       |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  performance
---------------------------+--------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch commit => has-patch


Comment:

 Commit keyword removed as it applies to the previous patch.

 [attachment:43142.2.diff] removes term caching from several instances in
 `src/wp-includes/taxonomy.php`:

 * `wp_insert_term()`: search for siblings with the same name
 * `wp_insert_term()`: search for all siblings
 * `wp_set_object_terms()`: search for old `tt_ids` using
 `wp_get_object_terms()`
 * `wp_set_object_terms()`: search for final `tt_ids` using
 `wp_get_object_terms()`
 * `_get_term_hierarchy()`: hierarchy update as in previous patch

 @boonebgorges would you mind taking another look at the new patch? It's
 the calls setting an objects terms that I am least sure about.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43142#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list