[wp-trac] [WordPress Trac] #43082: Add plugins search results: the plugin details modal opens in the thickbox modal

[WordPress Trac]

#43082: Add plugins search results: the plugin details modal opens in the thickbox
modal
-----------------------------+----------------------------------------
 Reporter:  afercia          |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.9.2
Component:  Plugins          |     Version:  4.9
 Severity:  normal           |  Resolution:
 Keywords:  has-screenshots  |     Focuses:  accessibility, javascript
-----------------------------+----------------------------------------
Changes (by afercia):

 * milestone:  Awaiting Review => 4.9.2


Comment:

 Seems to me this is a consequence of [41356]. The "custom modal" (which
 basically is some JS and CSS overriding) now kicks in only for modals with
 a `plugin-details-modal` CSS class, which in turn gets added only when
 clicking on the "More Details" link.
 Worth noting [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/js/plugin-install.js?rev=42403#L150 the click event attached to the
 More Details link] hasn't really ever worked in the Search results because
 the AJAX search rebuilds the HTML. Instead of attaching the event directly
 on the links, the event needs to be delegated.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43082#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform