[wp-trac] [WordPress Trac] #43082: Add plugins search results: the plugin details modal opens in the thickbox modal

[WordPress Trac]

#43082: Add plugins search results: the plugin details modal opens in the thickbox
modal
---------------------------------------+-----------------------------
 Reporter:  afercia                    |      Owner:
     Type:  defect (bug)               |     Status:  new
 Priority:  normal                     |  Milestone:  Awaiting Review
Component:  Plugins                    |    Version:  4.9
 Severity:  normal                     |   Keywords:  has-screenshots
  Focuses:  accessibility, javascript  |
---------------------------------------+-----------------------------
 To reproduce:

 - go in Plugins > Add New
 - open a plugin details modal, for example from the "Featured" tab, click
 on the BuddyPress "More details" link
 - the modal opens in the custom WordPress modal:

 [[Image(https://cldup.com/0c9aYWMwlg.jpg)]]

 - now go in the Search tab and search for "buddypress"
 - click on the BuddyPress "More details" link
 - the modal opens in the default thickbox modal:

 [[Image(https://cldup.com/E-KqeYJjtY.jpg)]]

 Worth noting the default thickbox modal doesn't handle well some
 accessibility requirements, for example tabbing is not constrained within
 the modal and Escape to close the modal works only in the modal top
 toolbar.

 Seems to me this worked correctly in 4.8 and was introduced at some point
 in 4.9.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43082>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform