[wp-trac] [WordPress Trac] #42643: FLV video format not playing

[WordPress Trac]

#42643: FLV video format not playing
--------------------------+-------------------------
 Reporter:  studiosx      |       Owner:  Clorith
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9.2
Component:  Media         |     Version:  4.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by Clorith):

 @birgire the notices you are seeing from Transmux are unfortunately what I
 was referencing in comment:14 which there's no way to pass logging-
 parameters for. They are just notices, and thus do not prevent further
 JavaScript from running as intended, but there's nothing we can do about
 these without a patch upstream
 ([https://github.com/mediaelement/mediaelement/issues/2480 I've created an
 issue for it]).

 For your 2nd question, I've always heard that `indexOf` is better
 performance wise than using `match`, so unless more regex is needed for
 checking, it's better to keep this approach.

 You are quite right about the translatable portion though, let's restore
 the previous behavior and use the `mejsL10n.strings["mejs.download-
 video"]` string, that'll cut out point 4 completely, but is a direct
 restoration of the previous behavior, so I like that better.

 I've made the string changes in [attachment:42643.4.patch]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42643#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform