[wp-trac] [WordPress Trac] #42643: FLV video format not playing

[WordPress Trac]

#42643: FLV video format not playing
--------------------------+-------------------------
 Reporter:  studiosx      |       Owner:  Clorith
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9.2
Component:  Media         |     Version:  4.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by birgire):

 Hi @Clorith, I tested the patch in [attachment:42643.3.patch] with
 [attachment:small.flv] and here are few notes:

 1. I get 139 js errors: {{{flv.min.js:6 [TransmuxingController] >
 DemuxException: type = CodecUnsupported, info = Flv: Unsupported codec in
 video frame: 2}}}, no matter if the patch [attachment:42643.3.patch] is
 applied or not. Maybe it's just my test install?
 2. Would it be possible to use e.g. {{{media.rendererName.match(
 /(flv|flash)/i )}}} (returns null or array) instead of multiple
 {{{indexOf()}}} like: {{{-1 !== media.rendererName.indexOf( 'flash' ) ||
 -1 !== media.rendererName.indexOf( 'flv' )}}} ?
 3. Shouldn't we have the ''Download'' string translatable? So in my
 language (Icelandic) I would see e.g.{{{<a href="http://test.localhost/wp-
 content/uploads/2018/01/small.flv?_=1">Sækja small.flv?_=1</a>}}}
 4. Should we remove the {{{?_=1}}} in the link text, e.g. {{{<a
 href="http://test.localhost/wp-
 content/uploads/2018/01/small.flv?_=1">Download small.flv</a>}}}, since
 the extra {{{?_=1}}} might be confusing to the user and since the
 downloaded file is also without it: {{{small.flv}}}?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42643#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform