[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
----------------------------------------+------------------------------
 Reporter:  johnbillion                 |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Login and Registration      |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  javascript
----------------------------------------+------------------------------

Comment (by adamsilverstein):

 Great idea @johnbillion - I agree we should have a show button wherever we
 have a password entry field. I could see some users not wanting password
 fields ever visible - especially on the login screen - for security
 reasons (someone could easily see your password or photograph it) Do you
 think we should have some sort of hook to disable?

 @Junaidkbr, @Iceable -  As a bit of background, the current code that uses
 a hidden mirrored field and toggles visibility instead of toggling the
 field type from password to text was  introduced for internet explorer 8
 compatibility, see https://core.trac.wordpress.org/ticket/32886#comment:2.
 Sadly, IE8 considered the field type property read only. I was responsible
 for writing most of that code and I can only cringe apologetically and say
 it was required at the time.

 Fortunately, we no longer need to support IE8 in core and can proceed with
 simpler code that uses the text/password type swap approach. We really
 should consider refactoring the existing code as well, the swapping fields
 approach works but creates some edge cases we have had to code around.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform