[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

WordPress Trac noreply at wordpress.org
Sun Jan 7 09:48:20 UTC 2018


#42888: Add a "Show" button next to password fields on mobile
----------------------------------------+------------------------------
 Reporter:  johnbillion                 |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Login and Registration      |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  javascript
----------------------------------------+------------------------------

Comment (by Junaidkbr):

 @Iceable is right, I also don't get the practice followed in /wp-admin
 /user-new.php to Show/Hide password. But this practice is followed on most
 of the web and most of the tutorials available for the practice teach the
 same practice as WordPress is using.

 I dug into both /wp-admin/user-new.php and /wp-login.php but I don't think
 we can follow the current the practice in /wp-login.php which is used
 already in /wp-admin/user-new.php. Reasons why
 1. The current approach uses jQuery while /wp-login.php use/load jQuery.
 So, either we have to include jQuery in login screen or rewrite the
 approach in vanilla JS.
 2. The login screen uses <p> tags to as wrapper to the input elements.
 Now, I am not deeply aware of the standards but following the approach in
 /wp-admin/user-new.php will break HTML standards and again we'll have to
 rewrite the structure.

 I think the best option here is to just create a simple input type toggle
 i.e. type="text/password" on login screen.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list