[wp-trac] [WordPress Trac] #43255: WP_Image_Editor::make_image leaves an output buffer open on failure

[WordPress Trac]

#43255: WP_Image_Editor::make_image leaves an output buffer open on failure
-------------------------------------------------+-------------------------
 Reporter:  gnif                                 |       Owner:  dhanendran
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9.5
Component:  Media                                |     Version:  3.5
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch fixed-      |     Focuses:
  major                                          |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:5 gnif]:
 > The patch committed is incorrect, it is uselessly checking again if
 `$stream` is set when it was already checked

 Ah, I missed the earlier check. Thanks for catching that!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43255#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform