[wp-trac] [WordPress Trac] #43255: WP_Image_Editor::make_image leaves an output buffer open on failure

[WordPress Trac]

#43255: WP_Image_Editor::make_image leaves an output buffer open on failure
-------------------------------------------------+-------------------------
 Reporter:  gnif                                 |       Owner:  dhanendran
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9.5
Component:  Media                                |     Version:  3.5
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch fixed-      |     Focuses:
  major                                          |
-------------------------------------------------+-------------------------

Comment (by gnif):

 The patch committed is incorrect, it is uselessly checking again if
 `$stream` is set when it was already checked on line 406

 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 image-editor.php?rev=42695#L406


 {{{
 406                if ( $result && $stream ) {
 407                             $contents = ob_get_contents();
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43255#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform