[wp-trac] [WordPress Trac] #42724: Options Media page hides breaks on desktop

WordPress Trac noreply at wordpress.org
Sat Feb 3 21:45:50 UTC 2018


#42724: Options Media page hides breaks on desktop
-------------------------------------+----------------------------
 Reporter:  garrett-eclipse          |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.9.4
Component:  Media                    |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  accessibility
-------------------------------------+----------------------------

Comment (by RavanH):

 Hi @afercia thanks for these considerations. Question: does the
 consistency/reusability rule not apply to common.css then? The rules that
 hide/show these break tags seem pretty much a special case as they only
 apply to the Settings > Media page...

 IMHO, these break tags do not belong there and should not be abused like
 that for responsive display purposes. It should be handled as is done on
 other settings pages. Take for example the Settings > Reading admin page
 where the select fields for front and blog page are displayed as inline-
 block (meaning horizontally) on desktop but as block (horizontally) on
 small screens due to this rule:
 {{{
 @media screen and (max-width: 782px) {
   #profile-page .form-table textarea, .form-table span.description, .form-
 table td input[type=text], .form-table td input[type=password], .form-
 table td input[type=email], .form-table td select, .form-table td textarea
 {
     ...
     display: block;
     ...
   }
 }
 }}}

 I understand this is a bit different case as it involves only one
 label/input pair per line, not two label/input pairs like on Settings >
 Media but still, a simpler more elegant solution than hidden break tags
 should be possible...

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42724#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list