[wp-trac] [WordPress Trac] #42724: Options Media page hides breaks on desktop

[WordPress Trac]

#42724: Options Media page hides breaks on desktop
-------------------------------------+----------------------------
 Reporter:  garrett-eclipse          |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.9.4
Component:  Media                    |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  accessibility
-------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 A few considerations:
 - The whole goal of `forms.css` is trying to have a consistent, reusable,
 set of CSS rules that can be applied everywhere. Ideally, there shouldn't
 be exceptions or special cases.
 - The breakpoint `max-width: 375px` that comes from #34539 seems a "magic
 number" to me. Where's the math behind it? Also, it's not used anywhere
 else in core. Worth reminding translations in other languages can use
 longer, sometimes much longer, strings and in this case the breakpoint
 should happen before 375 pixels.
 - Aligning labels inline with input fields is difficult. While it may be
 acceptable on large screens, I'd rather consider to always stack labels
 and fields vertically on small screens, even the ones with the `small-
 text` class (larger fields already stack).
 - The checkboxes "line wrap" issue: the current markup uses labels that
 wrap the checkboxes and it's basically impossible to avoid line wrapping.
 Using not-wrapping labels, as recommended by the Accessibility coding
 standards, would allow to style the checkbox and the label independently
 and solve the issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42724#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform