[wp-trac] [WordPress Trac] #44839: Privacy-data-requests-tables: Remove inline CSS, move it into a css file instead

[WordPress Trac]

#44839: Privacy-data-requests-tables: Remove inline CSS, move it into a css file
instead
-------------------------+-----------------------------
 Reporter:  birgire      |      Owner:  (none)
     Type:  enhancement  |     Status:  new
 Priority:  low          |  Milestone:  Awaiting Review
Component:  Privacy      |    Version:  4.9.6
 Severity:  normal       |   Keywords:
  Focuses:               |
-------------------------+-----------------------------
 In {{{WP_Privacy_Data_Export_Requests_Table}}} we have inline CSS:

 {{{
 $download_data_markup .= '<span class="export-personal-data-idle"><button
 type="button" class="button-link export-personal-data-handle">' . __(
 'Download Personal Data' ) . '</button></span>' .
   '<span style="display:none" class="export-personal-data-processing" >' .
 __( 'Downloading Data...' ) . '</span>' .
   '<span style="display:none" class="export-personal-data-success"><button
 type="button" class="button-link export-personal-data-handle">' . __(
 'Download Personal Data Again' ) . '</button></span>' .
   '<span style="display:none" class="export-personal-data-failed">' . __(
 'Download has failed.' ) . ' <button type="button" class="button-link">' .
 __( 'Retry' ) . '</button></span>';


   <span class="export-personal-data-idle"><button type="button"
 class="button export-personal-data-handle"><?php _e( 'Email Data' );
 ?></button></span>
   <span style="display:none" class="export-personal-data-processing button
 updating-message" ><?php _e( 'Sending Email...' ); ?></span>
   <span style="display:none" class="export-personal-data-success success-
 message" ><?php _e( 'Email sent.' ); ?></span>
   <span style="display:none" class="export-personal-data-failed"><?php _e(
 'Email could not be sent.' ); ?> <button type="button" class="button
 export-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
 }}}

 and in {{{WP_Privacy_Data_Removal_Requests_Table}}} we have:


 {{{
   $remove_data_markup .= '<span class="remove-personal-data-idle"><button
 type="button" class="button-link remove-personal-data-handle">' . __(
 'Force Erase Personal Data' ) . '</button></span>' .
     '<span style="display:none" class="remove-personal-data-processing" >'
 . __( 'Erasing Data...' ) . '</span>' .
     '<span style="display:none" class="remove-personal-data-failed">' .
 __( 'Force Erase has failed.' ) . ' <button type="button" class="button-
 link remove-personal-data-handle">' . __( 'Retry' ) . '</button></span>';

     <span class="remove-personal-data-idle"><button type="button"
 class="button remove-personal-data-handle"><?php _e( 'Erase Personal Data'
 ); ?></button></span>
     <span style="display:none" class="remove-personal-data-processing
 button updating-message" ><?php _e( 'Erasing Data...' ); ?></span>
     <span style="display:none" class="remove-personal-data-failed"><?php
 _e( 'Erasing Data has failed.' ); ?> <button type="button" class="button
 remove-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>

 }}}

 I wonder if we could remove this inline CSS and instead add something
 like:

 {{{
 .remove-personal-data-processing,
 .remove-personal-data-failed,
 .export-personal-data-processing,
 .export-personal-data-success,
 .export-personal-data-failed {
         display: none;
 }
 }}}

 in {{{list-tables.css}}} ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44839>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform