[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

WordPress Trac noreply at wordpress.org
Fri Aug 10 14:56:31 UTC 2018


#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  Iceable
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  accessibility,
  patch dev-feedback has-            |  javascript
  screenshots 2nd-opinion has-ux-    |
  feedback                           |
-------------------------------------+-------------------------------------

Comment (by afercia):

 Quickly looking at [attachment:"48222-5.diff"], one quick consideration:
 in the last years, WordPress has been progressively
 [https://core.trac.wordpress.org/query?keywords=~title-attribute removing
 title attributes from its codebase]. It's important to not introduce new
 title attributes, as [https://core.trac.wordpress.org/ticket/24766 they
 serve no useful purpose], they're available only to mouse users, and thus
 they're not accessible. Also, it's important to avoid to use `title` and
 `aria-label` attributes with the same value, as the same information may
 be announced twice. All the title attributes should be stripped out from
 the patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list